-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8 compatibility #328
Merged
Merged
PHP 8 compatibility #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@dkotter what additional work is needed to get this out of draft and open for review? |
dkotter
requested review from
a team and
peterwilsoncc
and removed request for
a team
June 16, 2022 20:59
peterwilsoncc
approved these changes
Jun 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR updates our PHPCS testing to ensure we run PHP compat tests on PHP 7.0+, hopefully flagging any issues with code that isn't compliant with our minimums. It also updates our PHPUnit tests to run on all PHP versions from 7.0 to 8.1, again hopefully catching issues that don't match our supported versions.
Note: the PHPCompatibility tool does not yet fully support PHP 8. So while the hope coming out of this PR is to have some automated scanning to ensure all existing code and any newly introduced code works on all supported PHP versions, until that tool adds full 8.0+ support, we can't guarantee that.
Alternate Designs
None
Possible Drawbacks
We are running more tests now, which will take up more time. Particularly for PHPUnit, we are running tests against PHP 7.0, 7.1, 7.2, 7.3, 7.4, 8.0 and 8.1. Could probably simplify that and only run against 7.0 and 8.1 and still catch most (if not all) issues.
Verification Process
Ensure newly added checks are passing
Checklist:
Changelog Entry
Credits
Props @dkotter