Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 compatibility #328

Merged
merged 10 commits into from
Jun 17, 2022
Merged

PHP 8 compatibility #328

merged 10 commits into from
Jun 17, 2022

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Feb 18, 2022

Description of the Change

This PR updates our PHPCS testing to ensure we run PHP compat tests on PHP 7.0+, hopefully flagging any issues with code that isn't compliant with our minimums. It also updates our PHPUnit tests to run on all PHP versions from 7.0 to 8.1, again hopefully catching issues that don't match our supported versions.

Note: the PHPCompatibility tool does not yet fully support PHP 8. So while the hope coming out of this PR is to have some automated scanning to ensure all existing code and any newly introduced code works on all supported PHP versions, until that tool adds full 8.0+ support, we can't guarantee that.

Alternate Designs

None

Possible Drawbacks

We are running more tests now, which will take up more time. Particularly for PHPUnit, we are running tests against PHP 7.0, 7.1, 7.2, 7.3, 7.4, 8.0 and 8.1. Could probably simplify that and only run against 7.0 and 8.1 and still catch most (if not all) issues.

Verification Process

Ensure newly added checks are passing

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Added - More robust PHP testing

Credits

Props @dkotter

@dkotter dkotter self-assigned this Feb 18, 2022
@jeffpaul
Copy link
Member

@dkotter what additional work is needed to get this out of draft and open for review?

@jeffpaul jeffpaul added this to the 1.8.0 milestone Jun 13, 2022
@dkotter dkotter marked this pull request as ready for review June 16, 2022 20:58
@dkotter dkotter requested review from a team and peterwilsoncc and removed request for a team June 16, 2022 20:59
Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dkotter dkotter merged commit 3bbff3e into develop Jun 17, 2022
@dkotter dkotter deleted the php8-compat branch June 17, 2022 15:57
@jeffpaul jeffpaul modified the milestones: 1.8.0, 1.7.2 Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants